Skip to content

chore: 🧑‍💻 update the commit message for cla signing #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented May 15, 2025

Description

If someone other than the signing user typed "recheck", it would cause the wrong user name to be referenced in the commit message...confusing. So removed that, and it's perfectly clear from the code changes who actually signed

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Tests

n/a


Summary by mrge

Updated the commit message for CLA signing to always reference the pull request number, making it clear who signed. This removes confusion when someone else types "recheck".

@sestinj sestinj requested a review from a team as a code owner May 15, 2025 22:37
@sestinj sestinj requested review from RomneyDa and removed request for a team May 15, 2025 22:37
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 15, 2025
Copy link

netlify bot commented May 15, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 4426a4f
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68266cb82b4f690008c16ea3

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit message looks good.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 16, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 16, 2025
@RomneyDa RomneyDa merged commit e2a575b into main May 20, 2025
121 of 127 checks passed
@RomneyDa RomneyDa deleted the nate/cla-commit-msg-update branch May 20, 2025 00:09
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants